[RNE Rewrite] Extract tokenizer try-lock helper - #1331
Merged
Conversation
barhanc
reviewed
Jul 29, 2026
Deduplicate the try-lock + liveness-check boilerplate repeated across the five TokenizerHostObject ops into a class-scoped tryLockUnique member, so callsites read self->tryLockUnique(rt, ctx) without lambdas or template parameters. Scoped to the tokenizer rather than shared across host objects to keep ergonomics simple and avoid coupling unrelated types.
msluszniak
force-pushed
the
@ms/tokenizer-lock-dedup
branch
from
July 29, 2026 13:14
4c603f9 to
f61becb
Compare
msluszniak
changed the title
msluszniak
commented
Jul 29, 2026
barhanc
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves the locking + boilerplate items of #1316. Extracts the try-lock + liveness-check block that was duplicated across the five
TokenizerHostObjectops into a single class-scopedtryLockUniquemember, so callsites readself->tryLockUnique(rt, ctx)— no lambdas or template parameters. Error messages are preserved verbatim. The helper is scoped to the tokenizer rather than shared across host objects, to keep callsites simple and avoid coupling unrelated types.TokenizerHostObjectkeeps its exclusivestd::mutex.Introduces a breaking change?
Type of change
Tested on
Testing instructions
Pure refactor with no behavior change: the extracted helper reproduces the exact same lock discipline and error strings as the inlined code.
Screenshots
Related issues
Resolves the locking/deduplication parts of #1316.
Checklist
Additional notes