Repository navigation
Fix: keep list and tuple element order in assigns - #1012
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
TermParser sorted list and tuple elements before building display nodes, so {:ok, 5} rendered as {5, :ok} and list diffs were applied by index to the sorted children.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1011
Summary
TermParser.to_children/1. Elements now display in their real order, so{:ok, 5}no longer renders as{5, :ok}.TermDifferare positional, so incremental updates now land on the right children and match a fresh render.Validation
mix test test/app/utils/term_parser_test.exs: the two new tests fail without the fix (32 tests, 2 failures) and pass with it (32 tests, 0 failures).mix test: 507 tests, 0 failures.mix format --check-formattedandmix credo: no issues.