Skip to content

fix: fix broken tests on Windows #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
s-elmer wants to merge 1 commit into
base: dev
Choose a base branch
from
+19 −11
Open

fix: fix broken tests on Windows #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions tests/PKForge.Engine.Tests/HaXAbilityTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,19 +55,27 @@ public void OffTableAbilitySurvivesSaveReloadOnGen7()
directory = directory.Parent;
var savePath = Path.Combine(directory!.FullName, "external", "PKHeX", "Tests", "PKHeX.Core.Tests", "TestData", "SM Project 802.main");

using (var session = new SaveEngineSession(File.ReadAllBytes(savePath)))
var haxSavePath = Path.Combine(Path.GetTempPath(), "hax-save.main");
try
{
var slot = session.Snapshot.Slots.First(s => s.Box >= 0 && s.Species is not null);
session.ApplyEdit(slot.Box, slot.Slot, new EntityEdit(Ability: Drought));
Assert.Equal(Drought, session.ReadEntity(slot.Box, slot.Slot).Ability);
File.WriteAllBytes("/tmp/hax-save.main", session.Serialize().ToArray());
}
using (var session = new SaveEngineSession(File.ReadAllBytes(savePath)))
{
var slot = session.Snapshot.Slots.First(s => s.Box >= 0 && s.Species is not null);
session.ApplyEdit(slot.Box, slot.Slot, new EntityEdit(Ability: Drought));
Assert.Equal(Drought, session.ReadEntity(slot.Box, slot.Slot).Ability);
File.WriteAllBytes(haxSavePath, session.Serialize().ToArray());
}

// Reload from disk bytes: the save file itself must carry the edit.
using (var reloaded = new SaveEngineSession(File.ReadAllBytes("/tmp/hax-save.main")))
// Reload from disk bytes: the save file itself must carry the edit.
using (var reloaded = new SaveEngineSession(File.ReadAllBytes(haxSavePath)))
{
var slot = reloaded.Snapshot.Slots.First(s => s.Box >= 0 && s.Species is not null);
Assert.Equal(Drought, reloaded.ReadEntity(slot.Box, slot.Slot).Ability);
}
}
finally
{
var slot = reloaded.Snapshot.Slots.First(s => s.Box >= 0 && s.Species is not null);
Assert.Equal(Drought, reloaded.ReadEntity(slot.Box, slot.Slot).Ability);
File.Delete(haxSavePath);
}
}
}
2 changes: 1 addition & 1 deletion tests/PKForge.Engine.Tests/ShowdownTeamAndBulkTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ Nonsense line that is not a set field
[Fact]
public void SplitCutsSetsWhereShowdownDoesAndDropsTeamHeaders()
{
var sets = ShowdownTeamService.Split(Team.Replace("\n", "\r\n"));
var sets = ShowdownTeamService.Split(Team.ReplaceLineEndings("\r\n"));
Assert.Equal(3, sets.Count);
Assert.Equal([(ushort)Species.Pikachu, (ushort)Species.Garchomp, (ushort)Species.Bulbasaur], sets.Select(s => s.Set.Species));
Assert.StartsWith("Pikachu @ Light Ball", sets[0].Text, StringComparison.Ordinal);
Expand Down