Skip to content

Reject negative native ByteBuffer capacity #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Reject negative native ByteBuffer capacity #332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ext/nio4r/bytebuffer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,16 @@ static size_t NIO_ByteBuffer_memsize(const void *data)

static VALUE NIO_ByteBuffer_initialize(VALUE self, VALUE capacity)
{
int requested_capacity;
struct NIO_ByteBuffer *buffer;
TypedData_Get_Struct(self, struct NIO_ByteBuffer, &NIO_ByteBuffer_type, buffer);

buffer->capacity = NUM2INT(capacity);
requested_capacity = NUM2INT(capacity);
if (requested_capacity < 0) {
rb_raise(rb_eArgError, "negative capacity given");
}

buffer->capacity = requested_capacity;
buffer->buffer = xmalloc(buffer->capacity);

NIO_ByteBuffer_clear(self);
Expand Down