Skip to content

Achieve 100% Ruby test coverage - #27

Merged
samuel-williams-shopify merged 1 commit into
mainfrom
full-test-coverage
Aug 20, 2026
Merged

Achieve 100% Ruby test coverage#27
samuel-williams-shopify merged 1 commit into
mainfrom
full-test-coverage

Conversation

@samuel-williams-shopify

@samuel-williams-shopify samuel-williams-shopify commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add focused coverage for renderer flags, helper methods, and header traversal
  • add Node#next_header, retain Node#next_heading as a compatibility alias, and recognize :header nodes correctly
  • make the base renderer raise NotImplementedError for unimplemented code blocks
  • use the stable CGI.escapeHTML API supported by Ruby 3.4 and newer
  • remove the vestigial blocksep, containersep, and @need_blocksep renderer machinery
  • document the behavior fixes in releases.md

Validation

  • bundle exec bake test — 2224 tests, 2362 assertions
  • COVERAGE=PartialSummary bundle exec bake test — 403/403 lines, 100.0%
  • bundle exec bake covered:validate --paths .covered.db
  • bundle exec bake decode:index:coverage lib — 69/69 public definitions documented
  • RuboCop passes for all changed Ruby files

@samuel-williams-shopify
samuel-williams-shopify force-pushed the full-test-coverage branch 2 times, most recently from a29e255 to da77d14 Compare August 20, 2026 07:23
@samuel-williams-shopify
samuel-williams-shopify merged commit 744408e into main Aug 20, 2026
24 of 28 checks passed
@samuel-williams-shopify
samuel-williams-shopify deleted the full-test-coverage branch August 20, 2026 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant