Repository navigation
Refactor the Windows native spec fixture to use ev_wrap.h - #129
Merged
Merged
Conversation
The fixture defined its own copy of the libev configuration, so settings added to ev_wrap.h, such as the evpipe handling from socketry#128, did not reach the libev that it tests. Include libev.c, which builds libev for the extension, instead. Drop ext/libev from the include path as well, so that ev_wrap.h cannot resolve to the generated header of the same name in ext/libev. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows native spec fixture defined its own copy of the libev configuration, so settings added to
ext/cool.io/ev_wrap.h, such as the evpipe handling from #128, did not reach the libev that it tests. This includeslibev.c, which builds libev for the extension, and dropsext/libevfrom the include path so thatev_wrap.hcannot resolve to the generated header of the same name there. WithEV_WIN32_STAT_CODEPAGEinev_wrap.hchanged toCP_ACP, the native spec now fails, while it passed before this change.Types of Changes
Contribution
🤖 Generated with Claude Code