Skip to content

Fix flaky TCPServer functional specs that listen on localhost #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Watson1978 merged 1 commit into from
Oct 21, 2026
Merged

Fix flaky TCPServer functional specs that listen on localhost #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions spec/tcp_server_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,9 +175,9 @@ def on_connect
it "connected socket called on_connect" do
begin
connected = false
server = Cool.io::TCPServer.new("localhost", port, ServerOnConnect, proc { connected = true })
server = Cool.io::TCPServer.new(HOST, port, ServerOnConnect, proc { connected = true })
loop.attach server
s = TCPSocket.open("localhost", port)
s = TCPSocket.open(HOST, port)
loop.run_once
s.close
expect(connected).to eq true
Expand All @@ -201,9 +201,9 @@ def on_close
it "closed socket called on_close" do
begin
closed = false
server = Cool.io::TCPServer.new("localhost", port, ServerOnConnect, proc { closed = true })
server = Cool.io::TCPServer.new(HOST, port, ServerOnConnect, proc { closed = true })
loop.attach server
s = TCPSocket.open("localhost", port)
s = TCPSocket.open(HOST, port)
loop.run_once
s.close
loop.run_once
Expand All @@ -229,10 +229,10 @@ def on_read(data)
it "server socket received data" do
begin
data = "aaa"
server = Cool.io::TCPServer.new("localhost", port, Echo, proc { |d| data = d })
server = Cool.io::TCPServer.new(HOST, port, Echo, proc { |d| data = d })
loop.attach server
thread = Thread.new { loop.run }
s = TCPSocket.open("localhost", port)
s = TCPSocket.open(HOST, port)
s.write "zzz"
sleep 0.1
expect(data).to eq "zzz"
Expand Down
Loading