Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behavior
The retry tests cover initial packet ordering, failure of a single packet, buffering before connection, and emissions from a connect handler. They do not cover retransmitting an in-flight unacknowledged packet after a transport disconnect without ackTimeout, or advancing the queue after exhausting a packet's retries.
New behavior
Add two tests using the existing real Socket.IO server fixture. The first closes the underlying connection after the server receives the unacknowledged packet and verifies it is retried on reconnection. The second verifies that one retry means two delivery attempts, the failed callback receives an error, and the next queued event is then acknowledged successfully.
The production implementation is unchanged.
Other information (e.g. related issues)
Validation on Node 24.21.0:
Mutation checks establish the new coverage:
These are additional tests for existing behavior, not a fix for an open issue.
The browser/Sauce suite was not run. The TypeScript compilation checks the client library; test files run through the existing
tsxtest runner.