chore: update to node24#1
Open
TerryHowe wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Terry Howe <terrylhowe@gmail.com>
|
@jhenstridge are you still maintaining this action (and its sister action-publish)? Could you please review this (and snapcore/action-publish#1) and make new releases of both actions? Thanks! |
bjorn
added a commit
to mapeditor/tiled
that referenced
this pull request
May 22, 2026
The action is effectively unmaintained (snapcore/action-build#1 has been open since April with no maintainer response). Replace it with a direct snapcraft invocation using --destructive-mode, which builds on the runner host instead of in LXD. Pin the job to ubuntu-24.04 so the host matches the snap's core24 base.
2 tasks
|
Any news? |
johnkerl
added a commit
to johnkerl/miller
that referenced
this pull request
Jun 30, 2026
* Update snapcore/action-build to node24 SHA, drop unused matrix snapcore/action-build@v1 targets Node.js 20, which is deprecated on GitHub Actions runners (forced to run on Node.js 24 with a warning). Upstream has an open PR to update (snapcore/action-build#1) but it has been stale for a while, so we pin directly to its HEAD SHA (edf78ca) until upstream merges and cuts a new tag. Also removes the `strategy.matrix.node-version: [20.x]` block, which was dead config — there was no `actions/setup-node` step consuming it. Fixes the warning seen in: https://github.com/johnkerl/miller/actions/runs/28449033140 Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> * comment --------- Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Actions is deprecating node20 in favour of node24. This PR updates the action runtime and
@types/nodeaccordingly, rebuildingdist/index.jswith ncc.Changes:
action.yml:node20→node24package.json:@types/node^20.14.10→^24.0.0dist/index.js: rebuilt with ncc🤖 Generated with Claude Code