Skip to content

Fixes for S3 integration test failures - #938

Merged
kuhe merged 1 commit into
developfrom
kuhe/fix/xml
Nov 14, 2026
Merged

kuhe merged 1 commit into
developfrom
kuhe/fix/xml

Conversation

@kuhe

@kuhe kuhe commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Fixes for problems discovered in this battery of tests: aws/aws-sdk-python#132

@kuhe
kuhe force-pushed the kuhe/fix/xml branch 2 times, most recently from 8f07839 to 8784be4 Compare November 13, 2026 20:32
@kuhe kuhe changed the title Call configured components instead of copies Fixes for S3 integration test failures Nov 13, 2026
if any(e.id.name == "NotFound" for e in operation.error_schemas):
code = "NotFound"
root = Element("Error")
wrapper_elements = ("Error",)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we want to map HEAD operation 404s specifically to the modeled NotFound error, or let them resolve as their existing CallError type.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For restxml this is fine

@kuhe
kuhe marked this pull request as ready for review November 13, 2026 21:19
@kuhe
kuhe requested a review from a team as a code owner November 13, 2026 21:19
@kuhe
kuhe merged commit 10b6947 into develop Nov 14, 2026
26 checks passed
@kuhe
kuhe deleted the kuhe/fix/xml branch November 14, 2026 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants