Skip to content

Fix aws-json type deser #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtdowling merged 2 commits into from
Jun 25, 2026
Merged

Fix aws-json type deser #1273

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
484c5a1
Fix aws-json type deser
mtdowling Jun 2, 2026
30d6922
Update aws/client/aws-client-awsjson/src/main/java/software/amazon/sm…
mtdowling Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...wsjson/src/main/java/software/amazon/smithy/java/aws/client/awsjson/AwsJson1Protocol.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,12 @@ public AwsJson1Protocol(ShapeId service) {
}

private static ShapeId extractErrorType(Document document, String namespace) {
// Per the awsJson1_0 spec, the __type discriminator may carry an over-the-wire namespace
// like "com.amazonaws.dynamodb.v20120810#ResourceNotFoundException" that doesn't match
// the model's namespace. Strip the namespace and let parseDiscriminator re-attach the
// service's namespace so registry lookup succeeds.
return DocumentDeserializer.parseDiscriminator(
ErrorTypeUtils.removeUri(ErrorTypeUtils.readTypeAndCode(document)),
ErrorTypeUtils.removeNamespaceAndUri(ErrorTypeUtils.readTypeAndCode(document)),
namespace);
}

Expand Down
Loading