Repository navigation
eve-online-mining-bot: aggressive=yes stands ready instead of fleeing under wormhole=yes - #496
Merged
Merged
Conversation
… under wormhole=yes wormholeSafetyStep's fallback, once engageHostiles finds nothing on the overview to lock, was unconditionally runAway regardless of why the grid did not read clean. Runs 22 and 23 (~13 and 213 fires of "leave rather than keep mining") show this firing almost entirely on CannotTellWhetherTheGridIsClean -- an absent or stale D-Scan window -- never on a genuine hostile. Under aggressive=yes this branch no longer calls runAway at all: a genuine hostile signal (SomethingIsOnTheGrid) that cannot yet be locked now launches drones and stands ready via the new readyDronesForGridHostile, and mere uncertainty triggers nothing -- no flee, no drone launch. aggressive=no is unchanged, and the shield-percentage emergency retreat is untouched. Fixes #495 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wormholeSafetyStep's fallback -- onceengageHostilesfinds nothing onthe overview to lock -- was unconditionally
runAway, regardless of whythe grid did not read clean. Two live six-hour runs with
wormhole=yes aggressive=yes(runs 22 and 23, both onIsolated Core Deposit) show thisfiring almost entirely on uncertainty:
or an engagement.
This is a wormhole -- leave rather than keep mining.fired ~13 times inrun 22 and 213 times in run 23, essentially every time on
CannotTellWhetherTheGridIsClean(no D-Scan window, or a stale scan) andnever on
SomethingIsOnTheGrid.(12 unloads -> 16), consistent with the ship heading back before a full
hold, interrupted by this branch.
Under
aggressive = yesthis branch no longer callsrunAwayat all:SomethingIsOnTheGrid-- a D-Scan sighting, oran overview pilot the rat-colour/warp-disrupt test does not catch) that
cannot yet be locked launches drones and stands ready instead, through the
new
readyDronesForGridHostile. Once drones are out, later readings ofthe same sighting launch nothing further and mining continues until
engageHostilesfinds something on the overview to send them after.CannotTellWhetherTheGridIsClean) triggers nothing atall -- no flee, no drone launch -- since aggressive mode does not run from
doubt, only from evidence.
aggressive = nois unchanged. The shield-percentage emergency retreat inreturnDronesAndRunAwayIfHitpointsAreTooLowOrWithoutDronesis untouched --this is scoped to the wormhole grid check alone.
Fixes #495
Test plan
elm-format --yesappliedelm make Bot.elm --output=out.js-- "Success! Compiled 15 modules"followed by the expected harmless "NO MAIN" error
D-Scan hostile contact fire
readyDronesForGridHostile; what to watch onthe next
wormhole=yes aggressive=yesrun is theCannotTellWhetherTheGridIsCleanfleeing disappearing from the decision log (the grid clause itself still
prints every reading via
describeWormholeSafety), and, if a real hostileever shows up on D-Scan first,
Nothing on the overview to lock yet -- launch drones and stand ready rather than run.appearing ahead of aneventual
Aggressive: fighting '...'.🤖 Generated with Claude Code