fix: devenv token verifier config should be scoped per family - #1382
Closed
huangzhen1997 wants to merge 2 commits into
Closed
fix: devenv token verifier config should be scoped per family#1382huangzhen1997 wants to merge 2 commits into
huangzhen1997 wants to merge 2 commits into
Conversation
|
👋 huangzhen1997, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
huangzhen1997
changed the title
huangzhen1997
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the devenv token-verifier configuration generation so it targets only the configured chain_family (defaulting to EVM), instead of scanning all chain selectors indiscriminately.
Changes:
- Filter
ChainSelectorspassed intoGenerateTokenVerifierConfigbyTokenVerifierInput.ChainFamily. - Set
ReplaceExisting: truewhen saving generated token-verifier config. - Add a local
filterSelectorsByFamilyhelper in both the monolith and phased-component paths.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| build/devenv/environment_monolith.go | Filter selectors by ChainFamily before generating token-verifier config; add helper. |
| build/devenv/components/tokenverifier/component.go | Apply the same family-based filtering in the phased tokenverifier component; add helper. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
makramkd
previously approved these changes
Aug 27, 2026
huangzhen1997
marked this pull request as draft
August 27, 2026 17:15
huangzhen1997
force-pushed
the
jh/token-verifier-config-gen-fix
branch
2 times, most recently
from
August 28, 2026 00:10
91e40d1 to
97dfc2e
Compare
|
Code coverage report:
|
archseer
reviewed
Aug 28, 2026
| ServiceIdentifier: "TokenVerifier", | ||
| ChainSelectors: selectors, | ||
| ChainSelectors: familySelectors, | ||
| ReplaceExisting: true, |
archseer
reviewed
Aug 28, 2026
| ServiceIdentifier: "TokenVerifier", | ||
| ChainSelectors: selectors, | ||
| ChainSelectors: familySelectors, | ||
| ReplaceExisting: true, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.