Harden validation for write report Solana - #742
Merged
Conversation
product-security-plaid-production
Bot
requested review from
amit-momin,
bolekk and
pavel-raykov
September 3, 2026 18:29
silaslenihan
reviewed
Sep 3, 2026
|
|
||
| var acc *soltypes.GetAccountInfoReply | ||
| acc, err = capcommon.WithQuickRetry(ctx, s.lggr, func(ctx context.Context) (*soltypes.GetAccountInfoReply, error) { | ||
| acc, err := s.SolanaService.GetAccountInfoWithOpts(ctx, soltypes.GetAccountInfoRequest{ |
Contributor
There was a problem hiding this comment.
This could lead to a state where an unrelated RPC failure results in a "System error" when a report potentially is already on-chain. Are we ok with that tradeoff?
Contributor
Author
There was a problem hiding this comment.
I think if the node experiences RPC failure it won't be able to retreive transmissionState from logs as well. Having RPC failure here will probably be even easier to debug in this case (easier than "transmission state not found..")
silaslenihan
reviewed
Sep 3, 2026
| acc, err = capcommon.WithQuickRetry(ctx, s.lggr, func(ctx context.Context) (*soltypes.GetAccountInfoReply, error) { | ||
| acc, err := s.SolanaService.GetAccountInfoWithOpts(ctx, soltypes.GetAccountInfoRequest{ | ||
| Account: soltypes.PublicKey(receiver), | ||
| Opts: &soltypes.GetAccountInfoOpts{}, |
Contributor
There was a problem hiding this comment.
should we match elsewhere like in forwarder_client and use CommitmentProcessed
Unheilbar
enabled auto-merge
September 3, 2026 20:59
amit-momin
reviewed
Sep 3, 2026
amit-momin
reviewed
Sep 3, 2026
amit-momin
approved these changes
Sep 3, 2026
|
dhaidashenko
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.