Repository navigation
style(dncl): show the notice of restricted blocks with the design tokens - #2265
Merged
smalruby3-editor-bot[bot] merged 2 commits intoNov 19, 2026
Merged
smalruby3-editor-bot[bot] merged 2 commits into
smalruby3-editor-bot[bot] merged 2 commits into
Conversation
The notice of the Code tab while the program is written in the Japanese tab used hard-coded yellow colors. It now uses the info colors of the alerts and a small secondary button of the design system. Refs #2264 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
🚀 Preview deployed (stg API): https://preview.smalruby.app/fix-ja-mode-notice-tokens-de4b00cb/ |
Refs #2264 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
smalruby3-editor-bot
Bot
merged commit Nov 19, 2026
447d74c
into
topic/japanese-mode-1731
11 checks passed
This was referenced Nov 19, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EPIC #1731 の確認ページ S1 の答え: 日本語タブで書いているあいだ、コードタブにブロックを制限していることと戻し方の案内を出す。
以前の日本語モードの通知バナー(「日本語タブで書いています:ブロックが制限されています」[すべてのブロックを使う]、
data-testid: dncl-mode-notice)は、日本語タブを分けたあとも残っていて、日本語で書いたあとコードタブを開くとワークスペースの右上に出る(下のスクリーンショット)。文言・動き(confirm → 全ブロックに戻す)は変えず、見た目だけをデザイントークンに合わせた。Changes Made
dncl-mode-notice.css: 直書きの黄色(#ffc107など)をやめ、smalruby-tokens.cssのお知らせの色($color-info-background・$color-info。components/alerts.md)、文字$color-text、角丸$radius-medium、余白$space-*に。[すべてのブロックを使う]は小さい副ボタンの形(白地・$color-border・$radius-small・:focus-visibleの紫の線)。docs/dncl/README.md: 見た目の説明とスクリーンショット0105-code-tab-notice-1280x800.png。Test Coverage
npx jest --runInBand test/unit/components/dncl-mode-notice.test.jsx(6 件通過)。CSS は postcss-import + postcss-simple-vars でコンパイルし未定義の変数が無いことを確かめた。elementFromPointで一番上)、地rgb(230, 240, 255)・枠rgb(77, 151, 255)・文字rgb(87, 94, 117)・ボタンの地が白であることを確かめた。その画面をdocs/dncl/screenshots/0105-code-tab-notice-1280x800.pngに置いた。Closes #2264
🤖 Generated with Claude Code