Repository navigation
Conversation
gastaldi
marked this pull request as draft
October 13, 2026 13:24
Contributor
|
Are there really downstream projects referencing |
Contributor
Author
|
@dmlloyd if they reference it, it would no longer work, since the plugin changed: https://help.sonatype.com/en/nexus-repository-maven-plugin.html |
dmlloyd
reviewed
Oct 13, 2026
gastaldi
marked this pull request as ready for review
October 13, 2026 15:39
Remove the nexus-staging-maven-plugin from both pluginManagement and the release profile, and drop the maven-gpg-plugin sign-artifacts execution. Also auto-activate the release profile when the performRelease property is set, so it is picked up by maven-release-plugin without passing -Prelease.
dmlloyd
approved these changes
Oct 15, 2026
dmlloyd
left a comment
dmlloyd
left a comment
Contributor
There was a problem hiding this comment.
Looks good; is this all ready?
Contributor
Author
|
Yes, it should be good now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
nexus-staging-maven-pluginfrom bothpluginManagementand thereleaseprofile, and drops themaven-gpg-pluginsign-artifactsexecution from thereleaseprofile.The
releaseprofile is now auto-activated by the presence of theperformReleaseproperty, somaven-release-pluginpicks it up without an explicit-Prelease.Also included:
version.nexus.staging.pluginproperty is dropped as well, per review feedback — downstream poms that still reference it can fix it when they bump the parent. (It would be broken anyway: the plugin itself has changed, see https://help.sonatype.com/en/nexus-repository-maven-plugin.html)distributionManagementis repointed off the legacys01.oss.sonatype.orgstaging/snapshot endpoints and onto Central Sonatype, under a singlesmallrye-publishserver id.The
version.surefirerevert from 3.6.0 back to 3.5.6 (SUREFIRE-3460) was split out into #692 to make it easier to track, so it is no longer part of this PR.