Repository navigation
feat: the docs header links the console and shows GitHub as an icon - #27
Merged
Merged
Conversation
The header takes the landing page's shape (sluiceway/landing #25): Go to console, linking https://console.sluiceway.dev, is the one thing in the bar that looks pressable. The Docs repo and GitHub text links become one small quiet GitHub mark (Octicons mark-github-16, aria-label "Sluiceway on GitHub") without an outline or shadow. The theme switch loses its outline and shadow, and search and the phone menu button their shadow. A Header override puts the button beside search below 50rem, so it stays in the bar on a phone, and in the right group from there. Below 500px the wordmark is read out but not shown, so everything fits at 320px. Between 50rem and 60rem search is its icon, so the theme switch is not cut off. The menu button is sized through --sl-menu-button-size, so it sits level with the rest of the bar. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs header now looks like the landing page's (sluiceway/landing #25), following the design system. Go to console (https://console.sluiceway.dev) is the one thing in the bar that looks pressable. The GitHub and Docs repo text links are replaced by one small quiet GitHub mark that links https://github.com/sluiceway/sluiceway. It has the aria-label "Sluiceway on GitHub", no label text, and no outline or shadow.
Headeroverride: the button sits beside search below 50rem, so it stays in the bar on a phone, and in the right group from 50rem up. It is the design system's default button atsm, the same as the landing page.SocialIcons: the Sluiceway text link, then the GitHub mark (Octiconsmark-github-16from @primer/octicons 19.38.0). Its hit area is 36px, or 44px on a touch screen.ink-muted, as on the landing page. Search and the phone menu button keep their outline and lose their shadow. The divider after the links is gone.--sl-menu-button-size, so it sits level with the rest of the bar (before, it sat 8px low). The menu's last row, with the links, the GitHub mark and the theme switch, is on one line.outboundevent, so nothing in analytics changes.Screenshots
Desktop, 1280px
Phone, 360px and 320px
The phone menu, scrolled to its last row
Checks
bun run checkpasses: lint, tokens, pin, release, typecheck, build, 617 tests.bun run links: 33003 links on 150 pages, all of them land./): 98–99 performance and 100 on everything else, except/what-it-looks-like/at 96 accessibility. That comes from two<summary>touch targets in the page content, not the header, and is above the 0.9 threshold.Not in this PR
Get started overflows to 362px on a phone: the inline code
.github/workflows/deploy-dashboard.ymlnever wraps (theme.css: "Stack ids never wrap"). That was already the case before this PR. At 320px it pushes the fixed menu button partly off-screen on that page.🤖 Generated with Claude Code