Conversation
DuckDB sizes its read_csv buffer as 16 × max_line_size and allocates it eagerly. The 256MB max_line_size raise (issue #787) thus demanded a 4 GiB block, causing OOM errors on hosts with a smaller memory_limit. Extract the read_csv from-expression into a new ReadCsvExpr helper that sets an explicit buffer_size equal to max_line_size, capping the allocation at the minimum needed to fit one line. Also add support for the memory_limit DuckDB session property, plus a regression unit test and replication config exercising a 5MB line under a 1GB memory limit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.