Skip to content

refactor: remove unused OpenTracingSpan function - #710

Merged
mwbrooks merged 1 commit into
mainfrom
mwbrooks-remove-dead-open-tracing-span
Oct 20, 2026
Merged

mwbrooks merged 1 commit into
mainfrom
mwbrooks-remove-dead-open-tracing-span

Conversation

@mwbrooks

Copy link
Copy Markdown
Member

Changelog

N/A - internal cleanup with no user-facing changes.

Summary

This pull request removes OpenTracingSpan from internal/slackcontext/slackcontext.go for maintainers, because the Go deadcode tool reports it as unreachable. Less unused code to read and keep compiling.

  • Removes OpenTracingSpan from internal/slackcontext/slackcontext.go
  • Removes its unit test from internal/slackcontext/slackcontext_test.go, which only tested this function

Testing

  1. Run go run golang.org/x/tools/cmd/deadcode@latest ./... | grep OpenTracingSpan and confirm there's no output
  2. Run go build ./... && go test ./... and confirm both pass

Requirements

@mwbrooks
mwbrooks requested a review from a team as a code owner October 20, 2026 17:02
@mwbrooks mwbrooks added this to the Next Release milestone Oct 20, 2026
@mwbrooks mwbrooks added code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment labels Oct 20, 2026
@mwbrooks mwbrooks self-assigned this Oct 20, 2026
@codecov

codecov Bot commented Oct 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.13%. Comparing base (fbadbd1) to head (9073903).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #710      +/-   ##
==========================================
+ Coverage   78.11%   78.13%   +0.01%     
==========================================
  Files         238      238              
  Lines       18117    18112       -5     
==========================================
- Hits        14152    14151       -1     
+ Misses       3965     3961       -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@srtaalej srtaalej left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mwbrooks

Copy link
Copy Markdown
Member Author

@srtaalej Thank you, thank you! :shipit:

@mwbrooks
mwbrooks merged commit a67878c into main Oct 20, 2026
13 checks passed
@mwbrooks
mwbrooks deleted the mwbrooks-remove-dead-open-tracing-span branch October 20, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants