[mwbrooks]

Changelog

N/A - internal cleanup with no user-facing changes.

Summary

This pull request removes Trigger.IsKnownType from internal/shared/types/triggers.go for maintainers, because the Go deadcode tool reports it as unreachable. Less unused code to read and keep compiling.

• Removes Trigger.IsKnownType from internal/shared/types/triggers.go
• Removes its unit tests in internal/shared/types/triggers_test.go, which only tested this method

Testing

1. Run go run golang.org/x/tools/cmd/deadcode@latest ./... | grep IsKnownType and confirm there's no output
2. Run go build ./... && go test ./... and confirm both pass

Requirements

• I've read and understood the Contributing Guidelines and have done my best effort to follow them.
• I've read and agree to the Code of Conduct.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.31%. Comparing base (63989fe) to head (6dbc441).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #709      +/-   ##
==========================================
+ Coverage   78.13%   78.31%   +0.17%     
==========================================
  Files         239      238       -1     
  Lines       18125    18297     +172     
==========================================
+ Hits        14162    14329     +167     
- Misses       3963     3968       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[zimeg]

@mwbrooks Thanks for keeping a search going toward less code! I like the change - ILTC?

[zimeg]

🦕 question: Do you know?

[mwbrooks]

🦕.isKnownType() => true