Skip to content

refactor: remove unused getProjectDirRelPath function - #707

Merged
mwbrooks merged 1 commit into
mainfrom
mwbrooks-remove-dead-get-project-dir-rel-path
Oct 16, 2026
Merged

mwbrooks merged 1 commit into
mainfrom
mwbrooks-remove-dead-get-project-dir-rel-path

Conversation

@mwbrooks

Copy link
Copy Markdown
Member

Changelog

N/A - internal cleanup with no user-facing changes.

Summary

This pull request removes getProjectDirRelPath from internal/runtime/python/python.go for maintainers, because the Go deadcode tool reports it as unreachable. Less unused code to read and keep compiling.

  • Removes getProjectDirRelPath from internal/runtime/python/python.go
  • Removes its unit tests from internal/runtime/python/python_test.go

Testing

  1. Run go run golang.org/x/tools/cmd/deadcode@latest ./... | grep getProjectDirRelPath and confirm there's no output
  2. Run go build ./... && go test ./... and confirm both pass

Requirements

@mwbrooks
mwbrooks requested a review from a team as a code owner October 16, 2026 18:04
@mwbrooks mwbrooks added this to the Next Release milestone Oct 16, 2026
@mwbrooks mwbrooks added code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment labels Oct 16, 2026
@mwbrooks mwbrooks self-assigned this Oct 16, 2026
@mwbrooks mwbrooks added code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment labels Oct 16, 2026
@codecov

codecov Bot commented Oct 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.14%. Comparing base (7d00c62) to head (05dea8f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #707   +/-   ##
=======================================
  Coverage   78.14%   78.14%           
=======================================
  Files         239      239           
  Lines       18135    18126    -9     
=======================================
- Hits        14171    14164    -7     
+ Misses       3964     3962    -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@WilliamBergamin WilliamBergamin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love these PRs 🙏

@mwbrooks

Copy link
Copy Markdown
Member Author

Thanks for the quick review @WilliamBergamin! 🙇🏻

I agree, it's nice to slim up the source code and the small PRs make it quick to review and feel confident. 👌🏻

@mwbrooks
mwbrooks merged commit e71f18c into main Oct 16, 2026
13 checks passed
@mwbrooks
mwbrooks deleted the mwbrooks-remove-dead-get-project-dir-rel-path branch October 16, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants