Repository navigation
Tifroz/attributed text - #146
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Skip project! Please use this space to describe your change and add any labels (bug, enhancement, documentation, etc.) to help categorize your contribution.
Please review the contribution guide at https://skip.dev/docs/contributing/ for advice and guidance on making high-quality PRs.
Skip Pull Request Checklist:
swift testCodex generated the code, I tested manually
Summary
Add editable attributed-text examples to the Text playground using the same Swift code in Lite, Fuse, and SwiftUI. The examples cover range fonts and colors, case-insensitive search, composed/decomposed Unicode matching, links, underline and strikethrough, baseline offsets, inherited styles, and edits after inline Markdown parsing.
Preserve the existing Text interpolation examples and add README links to the Foundation search limitations and SkipUI rendering limitations.
Source files:
Sources/Showcase/TextPlayground.swift,README.md.Use merged upstream dependencies for both modes. Lite uses SkipUI
55c7b41, which requires SkipFoundationba10460. Fuse uses SkipFuseUI3c884de.Source files:
Package.swift.Tests: Existing Lite and Fuse CI build workflows in
.github/workflows/showcase-lite.ymland.github/workflows/showcase-fuse.ymlcover dependency integration. Local validation is listed below.Split the Alert playground's long view expression into
controls,buttonAlerts, andbody. The unchanged upstream expression times out in Swift 6.4 during the iOS build; this small refactor allows the app to compile.Source files:
Sources/Showcase/AlertPlayground.swift.Limitations
Notes
Depends on merged SkipFoundation #143, SkipUI #597, and SkipFuseUI #164.