Locate Robolectric host libraries built by the swiftbuild engine - #121
Closed
piercifani wants to merge 1 commit into
Closed
piercifani wants to merge 1 commit into
piercifani wants to merge 1 commit into
Conversation
loadPeerLibrary only looked under <triple>/debug, the native build system layout. Swift 6.4 made swiftbuild the default SwiftPM engine on Linux, and it writes products to out/Products/Debug-linux-<arch> (and out/Products/Debug on macOS), so every Robolectric test failed with "missing library" once CI hosts moved to 6.4. Try the swiftbuild locations after the native one. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
Author
|
First-party confirmation: today's scheduled run of unchanged |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loadPeerLibraryonly looked for the Robolectric host library under the native build system's<triple>/debug/layout. Swift 6.4 made swiftbuild the default SwiftPM engine on Linux, and it writes products toout/Products/Debug-linux-<arch>/(out/Products/Debug/on macOS), so every Robolectric test now fails withmissing libraryon CI hosts that moved to a 6.4 toolchain,mainincluded. The loader now tries the native location first, then the two swiftbuild locations, and reports all of them when none exists.Evidence
Same workflow, same day, on a fork:
main: both ubuntu jobs fail withmissing library …/x86_64-unknown-linux-gnu/debug/lib*.so(468 occurrences each) https://github.com/piercifani/skip-bridge/actions/runs/35981813831main+ this commit:ubuntu-24.04andubuntu-24.04, nightly-mainpass https://github.com/piercifani/skip-bridge/actions/runs/35986700823Locally (macOS, native engine) the suite still passes 69/69, so the native path is unaffected.
🤖 Generated with Claude Code