fix(cursor): forward stream-json thinking events to the UI - #1045
Draft
joostfaassen wants to merge 1 commit into
Draft
fix(cursor): forward stream-json thinking events to the UI#1045joostfaassen wants to merge 1 commit into
joostfaassen wants to merge 1 commit into
Conversation
Cursor Agent emits type=thinking deltas over stream-json, but the CloudCLI Cursor bridge only handled system/user/assistant/result. Thinking was dropped, so the "Show thinking" toggle stayed empty for Cursor sessions (e.g. Grok). Buffer thinking deltas and emit kind=thinking on completed (or flush before assistant) so the existing UI path can render them.
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cursor Agent emits
type: thinking(delta/completed) over--output-format stream-json, but CloudCLI's Cursor bridge only handledsystem/user/assistant/result. Thinking events were dropped, so the Show thinking toggle stayed empty for Cursor sessions (reproduced with Grok 4.5 High Fast).This buffers thinking deltas and emits
kind: thinkingoncompleted(with a flush beforeassistantas a safety net), matching the UI path that already renders thinking blocks for Claude.Test plan
cursor-grok-4.5-high-fast)