fix: update stale Sonnet 4.6 labels to Sonnet 5 in the model picker - #1036
Open
zscgeek wants to merge 1 commit into
Open
fix: update stale Sonnet 4.6 labels to Sonnet 5 in the model picker#1036zscgeek wants to merge 1 commit into
zscgeek wants to merge 1 commit into
Conversation
…icker The 'default', 'sonnet', and 'sonnet[1m]' model options in CLAUDE_FALLBACK_MODELS still describe "Sonnet 4.6" even though the underlying `sonnet` alias already resolves to Sonnet 5 today (verified: `claude --model sonnet` reports "Sonnet 5, model ID claude-sonnet-5"). The Opus entry was already updated to say "Opus 4.8" - Sonnet's labels were simply missed in that pass. This is a label-only fix: the `value` fields (`default`, `sonnet`, `sonnet[1m]`) are unchanged, since those aliases are resolved live by Claude Code CLI itself and already point at the current model. Only the human-readable description text was stale, which made it look like Sonnet 5 wasn't available in the picker at all.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughChangesClaude model catalog
Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Claude model picker shows "Sonnet 4.6" everywhere (default description, Sonnet option, Sonnet 1M-context option), which makes it look like Sonnet 5 isn't available. It actually already is — the underlying `sonnet` alias resolves live, server-side, to whatever the current Sonnet model is:
```
$ claude --model sonnet -p "what model are you, exactly (full model id)?"
Sonnet 5, model ID `claude-sonnet-5`.
```
The Opus entries were already updated to say "Opus 4.8" in a previous pass — Sonnet's labels were simply missed.
Fix
Label-only change in `CLAUDE_FALLBACK_MODELS` (`claude-models.provider.ts`): updates the three "Sonnet 4.6" description strings (`default`, `sonnet`, `sonnet[1m]`) to "Sonnet 5". The `value` fields themselves are untouched — those aliases are resolved by Claude Code CLI itself and are already correct.
Testing
Summary by CodeRabbit