Skip to content

HTML API: Detect CDATA by adjusted node namespace - #38

Closed
sirreal wants to merge 1 commit into
trunkfrom
fix/html-api-cdata-namespace
Closed

sirreal wants to merge 1 commit into
trunkfrom
fix/html-api-cdata-namespace

Conversation

@sirreal

@sirreal sirreal commented Jun 9, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Keep CDATA detection tied to the adjusted node namespace instead of the integration-point tokenizer namespace.
  • Preserve SVG and MathML namespaces for CDATA sections inside HTML integration points.
  • Add regression coverage for SVG foreignObject and MathML annotation-xml.

Testing

  • Focused PHPUnit coverage for SVG and MathML HTML integration points.
  • HTML API PHPUnit coverage and PHPCS pass.
  • codex review --base trunk.

Trac ticket: https://core.trac.wordpress.org/ticket/65372

Use of AI Tools

AI assistance: Yes
Tool(s): Codex
Model(s): GPT-5.5
Used for: PR description cleanup and code review.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

gemini-code-assist[bot]

This comment was marked as off-topic.

@sirreal
sirreal marked this pull request as ready for review June 9, 2026 20:05
@github-actions

This comment was marked as off-topic.

@sirreal

sirreal commented Jun 10, 2026

Copy link
Copy Markdown
Owner Author

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

🤖 Generated with Claude Code

- If this code review was useful, please react with 👍. Otherwise, react with 👎.

@sirreal
sirreal force-pushed the fix/html-api-cdata-namespace branch from e5568ce to b1eb70f Compare June 29, 2026 15:57
@sirreal

sirreal commented Jul 15, 2026

Copy link
Copy Markdown
Owner Author

Superseded by WordPress#12539.

@sirreal sirreal closed this Jul 15, 2026
@sirreal
sirreal deleted the fix/html-api-cdata-namespace branch July 15, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant