fix(storage): validate checkpoint source offsets#3
Merged
Conversation
Require every decoded physical line to begin exactly where the previous line ended so tail candidates cannot publish raw records with gaps or overlaps. Cover deterministic chunk boundaries, large declared counts, and multi-record checkpoints that complete across repeated EOF observations.
Validate the sequence after a complete checkpoint before retaining its first record. This prevents an unrepresentable next sequence from surfacing only after the checkpoint has reached its commit boundary. Keep commit_pending transactional as a defensive invariant and cover the boundary with a retry test that proves pending and byte offsets remain untouched.
siriusctrl
marked this pull request as ready for review
July 22, 2026 10:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review finding
The decoder accepted line_end values that produced gaps or overlaps relative to the prior decoded line. The async forward reader naturally supplies contiguous offsets, but the public crate-internal tail-candidate seam could otherwise publish incorrect raw source offsets and committed boundaries.
Fix
Independent validation
This PR is based on agent/checkpoint-decoder and should be merged there before PR #2. It does not add epoch, truncate, replacement, or reopen behavior to the forward decoder.