Repository navigation
feat(sync): allow silencing startup sync notifications on mobile - #66
Open
scheerchristian wants to merge 1 commit into
Open
scheerchristian wants to merge 1 commit into
scheerchristian wants to merge 1 commit into
Conversation
Startup sync now honors a new "Startup sync notifications" toggle (default ON). When disabled, the startup sync runs silently: the engine swaps its active status bar for a no-op, so the mobile "Syncing…" and completion toasts never appear. Desktop is unaffected (it has no toast); watch mode and the mirror keep their own injected status bar. Closes siosig#64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a "Startup sync notifications" toggle (default ON). When disabled, the startup sync runs silently — the engine swaps its active status bar for a no-op, so the mobile "Syncing…" / completion toasts never appear.
Motivation
Closes #64 — on mobile the startup-sync toast has to be dismissed every time Obsidian reopens.
Changes
SyncEngine.syncManual()accepts asilentflag and swaps inNullStatusBarso no status surface is driven. Watch mode and the mirror keep their own injected status bar, so they are unaffected.main.tspassessilentfor the startup sync based on the new setting.startupSyncNotificationsEnabled(toggle,DEFAULT_SETTINGSdefaulttrue), declared insettingDefinitions.ts.NullStatusBardoc updated to reflect the new use.silentSync.test.tspins the silent/non-silent wiring at the realSyncEnginelevel;settingDefinitions.test.tsbaseline updated for the new row.Desktop is unaffected (it has no toast); the toggle is inert there.
Testing
pnpm test(a-no-nextcloud layer): 1797 passing.