Repository navigation
Version 1.4.2 - #1719
Merged
Merged
Version 1.4.2#1719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue of Pick and Omit dropping Optional and Readonly modifiers on shared properties when Intersect and Union are structurally collapsed. The update applies to the fast CollapseToObject path, retaining modifiers according to Intersection and Union rules. Updates are applied to Pick and Omit only. Index behaviors have been retained, but this PR does implement additional coverage to establish its Optional and Readonly property-indexing behavior.
Fixes: #1718
Updates
The updates ensure modifiers are retained on Pick and Omit.