Skip to content

chore(api-keys): remove the api-key-read-only flag - #9879

Merged
waleedlatif1 merged 1 commit into
stagingfrom
chore/remove-api-key-read-only-flag
Nov 11, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
chore/remove-api-key-read-only-flag

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Read-only API keys (#9855) are live: every production app pod runs v0.9.53, which enforces key access, and api-key-read-only is on in production AppConfig (feature-flags v45). This removes the flag so read-only key creation is always available.

  • Drop the flag from the registry, its API_KEY_READ_ONLY fallback env, and lib/api-key/feature-flag.ts
  • The create use case no longer checks the flag (resolveIssueSettings is now synchronous)
  • The create-key modal always offers Access, except where a key must be full access (deploy modal, workflow MCP server)
  • Remove the flag from the workspace, organization and account layouts and from WorkspaceFeatureFlags
  • Remove the flag-off integration test and the account layout test that only covered passing the flag through
  • Docs: drop the caveat that Access may be hidden because read-only keys aren't available yet

Enforcement of read-only keys never depended on the flag, so this changes nothing for existing keys.

Rollout

After this ships to production, remove api-key-read-only from the prod feature-flags AppConfig document. Self-hosted deployments get read-only keys on upgrade. Rolling back below v0.9.53 still requires revoking read-only keys first, since older code serves them as full access.

… keys are live

Every production pod runs v0.9.53, which enforces key access, and the flag is on in prod AppConfig. Read-only key creation is now always available: the create modal always offers Access (except where a key must be full access), and the create use case no longer consults the flag.
@vercel

vercel Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 11, 2026 5:48pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 12 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Removes the rollout flag so read-only API keys are always available.

  • People can create read-only API keys without a rollout flag.

Known limitation acknowledged by waleedlatif1: rolling back below v0.9.53 requires revoking read-only keys first, because older releases treat them as full access.

Reviews (1) · Last reviewed commit: "chore(api-keys): remove the api-key-read..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit abc5ead into staging Nov 11, 2026
59 of 61 checks passed
@waleedlatif1
waleedlatif1 deleted the chore/remove-api-key-read-only-flag branch November 11, 2026 17:46
waleedlatif1 added a commit that referenced this pull request Nov 11, 2026
Removes the api-key-read-only flag from the Platform surface too: the
surface contract, organization surface resolver, the read-only key hook,
and both create-key modals now always offer read-only access.

This branch was successfully deployed

1 active deployment
Preview — 1ae4d77e Deployed Nov 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant