Repository navigation
fix(mistral): say V3 parses an uploaded or referenced PDF, and bound Max Images at 100 - #9872
Merged
Merged
Conversation
…Max Images at 100
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Medium impact] The PR appears safe to merge; the previous docs issue is fixed and no new issues were found. SummaryCorrects V3 input guidance and shares the 100-image cap across the block and server.
Reviews (2) · Last reviewed commit: "docs(mistral): the V3 intro takes an upl..." · Reviewed by Greptile |
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two review findings on the Mistral Parser image extraction (#9856), raised on the v0.9.53 release PR.
normalizeFileInputwith "PDF document is required"). It now says "an uploaded PDF or a file from a previous block". V1 and V2 do accept URLs and are unchangedMAX_OCR_EXTRACTED_IMAGESintools/mistral/types.ts(type-only imports), shared by the block's bound, the server'simage_limitclamp, and the extraction loop. The placeholder and tool description keep the literal 100 because the docs generator strips${...}from source stringsNo effect on v1/v2 (they never request images), the knowledge-base OCR path (doesn't use
imageLimit), or agent-tool calls (imageLimitis user-only).Type of Change
Testing
bunx vitest run lib/internal/mistral tools/mistral blocks— 852 passedcheck-block-registry.ts origin/staging,check:docs,check:integration-catalog,check:canvas-sentences,check:client-boundary,check:tool-registry-boundary --check,check:comment-hygiene; regenerated docs and integrations cataloglint:check+type-checkvia the pre-push hook; full gate left to CIChecklist
test-auditauthoring gate)