Skip to content

fix(redaction): keep Infisical secret names visible, and correct the NO_PROXY docs - #9867

Closed
waleedlatif1 wants to merge 2 commits into
stagingfrom
fix/redaction-infisical-secret-names
Closed

waleedlatif1 wants to merge 2 commits into
stagingfrom
fix/redaction-infisical-secret-names

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

Type of Change

  • Bug fix

Testing

  • bunx vitest run lib/core/security/redaction.test.ts — 76 passed; restoring the secretKey pattern turns the secretKey non-sensitive case red
  • check:docs, check:site-urls
  • lint:check + type-check via the pre-push hook; full gate left to CI

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Building Building Preview Nov 11, 2026 12:37am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

Folded into the single round-2 release cleanup PR (fix/release-final-leftovers-1110), which takes both commits here unchanged: the reviewed secretKey redaction fix and the networking.mdx NO_PROXY wording. Closing so there is one PR.

@waleedlatif1
waleedlatif1 deleted the fix/redaction-infisical-secret-names branch November 11, 2026 00:39
@greptile-apps

greptile-apps Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 3/5

[Critical impact] The PR changes a shared redaction rule used across several ways people inspect run data.

Restore masking for bedrockSecretKey before merging so AWS credentials do not appear in logged inputs.

Findings

  1. P1 Security Bedrock keys appear in logs ▶

Summary

This PR keeps Infisical secret names visible and corrects the outbound proxy documentation.

  • Infisical secret names stay visible while Convex deploy keys stay masked.
  • The networking guide explains the SSRF guard's curl-style NO_PROXY matching.

waleedlatif1 explicitly states that keeping bare secretKey visible is intentional because Infisical uses that field for secret names.

Reviews (1) · Last reviewed commit: "docs(networking): the SSRF guard matches..." · Reviewed by Greptile

Comment on lines +32 to 34
// Convex's `deployKey`. A bare `secretKey` is left out: Infisical returns each
// secret's name in that field, and redacting it would hide every listed name.
/^.*deploy[_-]?key$/i,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 security Bedrock keys appear in logs

Removing the whole secretKey suffix pattern also stops hiding bedrockSecretKey, which holds an AWS secret access key. When a user types that key directly into a Bedrock block, the resolver keeps the literal value and the block logger passes it through redactApiKeys. The key now appears in logged inputs and the console.

Keep bare secretKey visible for Infisical, but retain coverage for credential fields such as bedrockSecretKey and restore its regression test.

How this was verified: The Bedrock password field flows into logged block inputs, while the placeholder projection preserves directly typed values and the remaining key patterns do not match bedrockSecretKey.

This branch was successfully deployed

1 active deployment
Preview — 67d652d2 Deployed Nov 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant