Repository navigation
fix(sim-setup): quote env values containing $ so dotenv, Bun, and Compose don't expand them - #9861
Merged
Merged
Conversation
…pose don't expand them
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge; no actionable new issue was found. Summary
Reviews (2) · Last reviewed commit: "fix(sim-setup): write $ as \$ in double ..." · Reviewed by Greptile |
…n, and Compose all read literally
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This was referenced Nov 11, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sim-setupwrote env values containing$unquoted (SMTP_PASSWORD=pa$$word). Next's dotenv, Bun, and Docker Compose all expand$NAMEin unquoted values, so a password or API key containing$was silently corrupted and auth failed with no error$NAMEeven inside single quotes. Values containing$are now written as"…\$…", the one form Next, Bun, and Compose all read literally; a value that also has a double quote, backslash, or backtick is refused with a clear message instead of written in a form that would expandparseValueunescapes\$in double-quoted values so sim-setup reads its own writes back unchangedType of Change
Testing
packages/sim-setup/src/env-files.test.ts: the written file is loaded through@next/envloadEnvConfigforpa$$word,key$HOME,key${HOME}suffix,it's $5, plus aparseEnvround-trip; all 5 new cases fail on the pre-PR code (and on a single-quote attempt) and pass now, 15/15docker compose runwithenv_filechecked by hand against the same written file: every value read literallyChecklist
test-auditauthoring gate)🤖 Generated with Claude Code