Repository navigation
improvement(api): release audit follow-ups for v2 member analytics, workflow access middleware and docs - #9858
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
All reported issues were addressed across 9 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
[Medium impact] The PR appears safe to merge. SummaryAdds member analytics to the v2 workspace routes and removes an unused workflow access branch.
No actionable issues found. Review used code inspection; tests were not run. Reviews (3) · Last reviewed commit: "improvement(api): release audit follow-u..." · Reviewed by Greptile |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
…orkflow access middleware and docs
9b60201 to
de7e736
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Drops the response cap and crawl depth (landed in #9860), CONTRIBUTING (#9860), Firecrawl search sources (on hold), Databricks JSON caps (#9859), and the workflow middleware and route-policies cleanups (#9858). Drops the NO_PROXY entry-syntax docs line (owned by a separate NO_PROXY change). Generated files regenerated on current staging.
Summary
workspace_member_role_changed/workspace_member_removedanalytics events as the in-app routes (user-credential principals only, matching the other v2 routes)requireDeployment=truebranch fromvalidateWorkflowAccess; every caller already passedfalse, and the dead branch authenticated API keys without the read-only checkv2WorkspaceErrorPoliciesand inlined the busy-error predicateType of Change
Testing
app/api/workflows,app/api/resume,app/api/v2/workspaces,lib/workspaces/apisuites (172 tests) andbun run lint; type-check and audits run in CIChecklist
test-auditauthoring gate)