Skip to content

fix(firecrawl): complete v2 response and depth compatibility - #9847

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/firecrawl-v2
Nov 10, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/firecrawl-v2

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Finish Firecrawl v2 response handling while preserving workflow outputs: search returns its web result array and map returns URL strings.
  • Preserve legacy crawl path-depth limits with v2 URL filters and keep discovery depth independent. Retain the v1 search default of five results.
  • Refresh generated documentation and tool metadata. All Firecrawl endpoints already target v2; no SDK upgrade is needed.

Type of Change

  • Bug fix

Testing

  • Demonstrated the original 10 regressions and five combined-filter index-page regressions failing before their fixes. All 49 Firecrawl tests pass.
  • Checked 361 URL paths at three depth limits against Rust's regex engine, including index-file exceptions.
  • Ran root VITEST_MAX_WORKERS=4 bun run test, bun run lint, bun run type-check, bun run check:audits, and the block-registry check against origin/staging.
  • Verified request and response changes against the official v2 migration guide. Live provider requests were not run.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 10, 2026 7:52pm UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no new actionable issues were found.

Summary

This PR updates Firecrawl v2 calls while keeping workflow outputs stable.

  • Firecrawl crawl limits URL depth without changing discovery depth.
  • Firecrawl search returns web results and defaults to five.
  • Firecrawl map gives workflows a list of URL strings.

Reviews (2) · Last reviewed commit: "fix(firecrawl): preserve index pages wit..." · Reviewed by Greptile

Comment thread apps/sim/tools/firecrawl/crawl.ts Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 9 files

Confidence score: 3/5

  • In apps/sim/tools/firecrawl/crawl.ts, the depth exclusion also drops /index.html and /index.php with maxDepth: 1 and includePaths: ['^/docs'], so otherwise allowed pages won't be crawled. Preserve the index-file exception when applying the exclusion.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/sim/tools/firecrawl/crawl.ts">

<violation number="1" location="apps/sim/tools/firecrawl/crawl.ts:166">
P2: Preserve the `/index.html` and `/index.php` exception when applying this depth exclusion; with `maxDepth: 1` and `includePaths: ['^/docs']`, this pattern excludes those otherwise allowed pages.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/tools/firecrawl/crawl.ts Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 9 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/tools/firecrawl/crawl.ts Resolved

This branch was successfully deployed

1 active deployment
Preview — 7b3cae12 Deployed Nov 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant