Repository navigation
improvement(search): shorter live document IDs - #9794
Conversation
Live search now mints live2: IDs: readable, ~-separated, percent-escaped provider fields with no reader or scope, about a quarter the length and tokens of the base64 JSON form. Reads derive the reader and scope from the request; account resolution and provider verification remain the authorization. Earlier live: IDs still read with their reader and scope checks. Document ID filters, Assistant scope intersection, and citation IDs compare by the decoded document identity, so both forms of one document match.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
[Medium impact] The PR appears safe to merge; no new actionable issues were found. SummaryThis PR replaces long live document references with shorter
No new actionable issues were found. Reviews (3) · Last reviewed commit: "fix(search): bind live IDs to their read..." · Reviewed by Greptile |
There was a problem hiding this comment.
All reported issues were addressed across 10 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
live:+ base64 of a JSON object naming the reader, scope, account and document (~270-375 chars, ~175-245 tokens). Clients re-read them every turn and copy them verbatim into readslive2:IDs:provider~account~id~container~kind~thread~revision~binding~checksum, ~65-135 chars (~47-64 tokens)%and control characters are escaped, so an ID is never longer than the old form and any string encodeslive:IDs still read, with their reader/scope check unchangedType of Change
Testing
reference.test.ts+ updated application/filters/MCP server tests; 6 new tests seen failing on the previous encoding (truncation, edit, unpaired surrogate, length, mixed-form batch dedupe) and passing nowlib/sim-search/live,lib/knowledge/search,lib/knowledge/mcp, mothership knowledge tools, chat citations, message-content citations (1,356 passed); biome on changed files; type-check, audits and integration in CIChecklist
test-auditauthoring gate)🤖 Generated with Claude Code