Repository navigation
Conversation
Classify only the configured self-hosted hostname as public address space so Chromium Local Network Access checks do not reject the main navigation. Keep the process-wide checks enabled for arbitrary browser destinations.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The change affects the configured server navigation in Sim Desktop. The PR appears safe to merge, with a non-blocking startup recovery issue that can require one extra restart. Findings
SummaryThis PR adds a Chromium address-space override for the configured self-hosted hostname.
Reviews (1) · Last reviewed commit: "fix(desktop): allow private self-hosted ..." · Reviewed by Greptile |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow Sim Desktop to load a configured self-hosted origin when its hostname resolves to private address space.
Chromium's Local Network Access checks can reject the main-frame navigation with
ERR_ADDRESS_UNREACHABLE (-109)before Electron reaches the deployment or can present a permission prompt. The configured Sim origin is already an explicit trust decision and owns the shell preload bridge.This change adds an
ip-address-space-overridesentry for only the configured self-hosted hostname. It does not disable Local Network Access checks process-wide, so arbitrary built-in browser destinations retain the protection. Sim-operated and loopback origins are unchanged. Server changes already relaunch the app, so the override follows the newly configured origin on restart.Reproduction
Tested with Sim Desktop
0.9.46/ Electron43.8.1and a self-hosted HTTPS origin resolving to192.168.50.153:curland a normal browser reached the deployment successfullyload_failurewithERR_ADDRESS_UNREACHABLE (-109)--ip-address-space-overrides=<host>=publicloaded successfullyValidation
bun run --cwd apps/desktop test -- config.test.tsbun run --cwd apps/desktop lint:checkbun run --cwd apps/desktop type-checkbun run --cwd apps/desktop buildCSC_IDENTITY_AUTO_DISCOVERY=false bun run --cwd apps/desktop package:dir