Repository navigation
improvement(integrations): show the sites an Atlassian account reaches - #9762
Merged
Merged
Conversation
Adding a site to an Atlassian login refreshes the existing account, so the page looked unchanged after a successful add. Record the sites a grant reaches when it connects, list them on the account, count them in the accounts list, and confirm a successful connect or reconnect with a toast.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
 [Medium impact] The PR appears safe to merge, with no outstanding actionable findings. SummaryRecords Atlassian sites for display and shows connection success messages.
Reviews (2) · Last reviewed commit: "fix(integrations): bound recorded sites ..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 9 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
…t cannot list them
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
accessible-resourcesand stores each site's name and origin in the account's provider metadata. The listing is best effort: a failed or malformed response never fails the connection, and Search still lists sites live on every request, so the stored list is display onlyprovider_metadatais jsonb. Existing accounts show their sites after their next reconnectType of Change
Testing
managed-oauth.test.ts: sites recorded from the grant with non-HTTPS and unnamed entries dropped; connecting still succeeds without a list after an error status, a network failure, or a malformed body. The recording case failed before the changemultiple-provider-accounts.integration.tson real Postgres: the account read returns stored sites and ignores malformed entries. Failed before the changelib/auth/connectors,lib/credential-groups,app/o,lib/knowledge/application,lib/mothership/applicationcheck:comment-hygiene,check:utils,check:test-patterns,check:source-conventions,check:file-names,check:explicit-any,check:boundaries,check:client-boundary,check:api-validation:strict,check:schema-mock; drizzle-kit reports no schema change; type-check on pre-pushcheck:auditsand the full suite run in CIChecklist
test-auditauthoring gate)