Repository navigation
fix(logs): log the webhook poll id and emitted event id under their own names - #9747
Merged
Merged
Conversation
…wn names Webhook polls and Sim events logged their own generated ids as requestId, which the poll route's request context overwrites, so the ids never reached a log line. The orchestrator now binds each poll's id on the handler logger as pollId, handlers drop their per-line requestId fields, and the event emitter logs its per-event id as dispatchId. The ids passed downstream as each execution's request id are unchanged.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Medium impact] The PR appears safe to merge; log IDs stay distinct and downstream execution IDs are preserved. SummaryThis PR separates generated poll and event IDs from the HTTP request ID in logs.
No actionable issues were found. Review checks were source-based; no tests were run. Reviews (1) · Last reviewed commit: "fix(logs): log the webhook poll id and e..." · Reviewed by Greptile |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requestId. The logger lets the request context own that field, and both run inside the poll route's request context, so the poll id and the per-event id never reached a log linepollIdand binds it on the handler logger withwebhookId, so every handler line carries it{ requestId }fields from all eight polling handlers andskipAdmissionRefusedPoll, plus the helper params and the HubSpot filter-limit error prefix that only fed themdispatchIdrequestIdtoprocessPolledWebhookEventand OAuth refresh, and each emitted event still passes its own, so execution request ids and idempotency keys stay unique per poll and per eventadd-triggerskill: polling handlers log throughctx.loggerand never add{ requestId }Type of Change
Testing
workspace-events/emitter.test.tspasscheck:source-conventions,check:comment-hygiene,check:test-patterns,check:utils; type-check via the pre-push hookChecklist
test-auditauthoring gate)