Fix join state checks for server switches#19
Open
frederickbaier wants to merge 1 commit into
Open
Conversation
FllipEis
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Players who were already connected to the proxy could be blocked while switching servers because the proxy-level join-state check ran for every server connect event, not only for the initial proxy join. That made maintenance/full-network checks apply again during normal server switches before the target server join-state check ran. Server names with hyphenated group names such as
cave-ffa-1also failed the join-state service parser, so target service join states could be missed and fall back incorrectly.Changes
previousServer == null.JOIN_PROXYor a missing current server.cave-ffa-1resolves to groupcave-ffaand numerical id1.Type of Change
Behavior Change
Before:
Proxy-level join-state and full-network checks ran again during server switches, and hyphenated service names like
cave-ffa-1did not parse as<group>-<id>.After:
Proxy-level join-state checks run only on initial proxy join, target server join-state checks still run on switches, and
cave-ffa-1resolves to thecave-ffaservice with numerical id1.Pre-Deployment Migrations
No migrations required before deploying.