Repository navigation
Fix --raise-error flag parsing in preprocess scripts - #1761
Merged
Merged
Conversation
Contributor
|
This change makes sense, but there are some preprocessing ISO slurm configs that make use of the current format that will be broken if we update it, so it is probably better to leave it as is for now. |
Contributor
|
I think if you go in and change the iso-sat slurm scripts that'll break I'm ok accepting this. |
Contributor
|
Given companion pr in iso-sat happy to merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
type=boolparses any non-empty string asTrue, so--raise-error Falseenables it, and bare--raise-errorfails asking for a value.This is a breaking change: existing callers need to drop the value.