Repository navigation
Handle corner case in crosstalk sim - #1759
Merged
Merged
Conversation
When working with real observations, make sure that detectors with invalid pointing or metadata properties are flagged.
ttsan2521
reviewed
Oct 2, 2026
| # Get crosstalk strength, chi | ||
| # Generate output data by mixing input data | ||
| for det_target in good_dets: | ||
| if det_target not in dPhi0dT: |
Contributor
There was a problem hiding this comment.
Is this 2nd check to catch any additional detector cuts in dPhi0dT , that were not captured in good_dets, such as bad el values?
Member
Author
There was a problem hiding this comment.
Correct, this check is just for the case of real observations and when using per-detector elevation values.
ttsan2521
approved these changes
Oct 2, 2026
ttsan2521
left a comment
ttsan2521
left a comment
Contributor
There was a problem hiding this comment.
Just a clarifying comment on my end on some of the multiple detector cut checks. Never hurts to have more. The rest looks good. Thanks for working on this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working with real observations, make sure that detectors with invalid pointing or metadata properties are flagged.