Add set_hvac - #267
Add set_hvac#267mmccrackan wants to merge 5 commits into
Conversation
BrianJKoopman
left a comment
BrianJKoopman
left a comment
There was a problem hiding this comment.
This looks good, just one question I'm wondering about. (And thanks for adding tests!)
| (["boosters", "fans"], ["on", "on"]), | ||
| (["boosters", "fans"], "off"), | ||
| (["fans"], 50), |
There was a problem hiding this comment.
Is this representative of actual targets? Or at they just dummy values for the test? The list isn't clear to me in the socs docs either, but from there I would have expected names like "Fan Yoke Traverse A Electronic Space".
There was a problem hiding this comment.
Yeah they are actual targets that are treated a bit differently. See: https://github.com/simonsobs/socs/blob/4413b27a567feee21a9e331bc60497c8458448aa/socs/agents/acu/agent.py#L3643 where they are parsed.
There was a problem hiding this comment.
Ah, gotcha, can you list 'fans, boosters, and heaters' and valid targets in the docstring here?
This branch has not been deployed
2 participants
Adds
set_hvacfor turning on the LAT boosters and fans.