pysmurf-controller: Update sodetlib version to v0.6.8 - #1108
Merged
Merged
Conversation
Updates sodetlib repo release tag to v0.6.7, which fixes the polarity issue in _fit_tau_effs
BrianJKoopman
left a comment
BrianJKoopman
left a comment
Member
There was a problem hiding this comment.
Great, thanks for the PR! Has this been tested at all yet?
Contributor
Author
|
The change of sodetlib was tested for many old observations and verified. |
BrianJKoopman
self-requested a review
September 29, 2026 18:56
BrianJKoopman
approved these changes
Sep 29, 2026
BrianJKoopman
left a comment
BrianJKoopman
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates sodetlib repo release tag to v0.6.8, which fixes the polarity issue in _fit_tau_effs
Motivation and Context
This will fix the issue of tau_eff fit simonsobs/sodetlib#518
How Has This Been Tested?
EDIT: The change of sodetlib was tested for many old observations and verified.
Checklist:
AI Usage Disclosure
AI is not used