Skip to content

polarization covariances (all)#65

Open
xzackli wants to merge 32 commits into
simonsobs:masterfrom
xzackli:efstathiou
Open

polarization covariances (all)#65
xzackli wants to merge 32 commits into
simonsobs:masterfrom
xzackli:efstathiou

Conversation

@xzackli

@xzackli xzackli commented Jul 9, 2023

Copy link
Copy Markdown
Contributor

This PR will contribute some codes to compute a subset of spin-2 covariances. BB-related covariances will likely still require some aid from simulations. In this PR I'll focus on cleaning up the TTTT code enough to write legible EEEE and TETE.

@xzackli

xzackli commented Jul 10, 2023

Copy link
Copy Markdown
Contributor Author

Tests appear to be failing because of a pixell issue upstream.

@xgarrido

Copy link
Copy Markdown
Collaborator

This is due to pillow version 10.0 (required by pixell) XingangPan/DragGAN#152 I don't really know how to proceed since it's mainly a pixell issue (we can downgrade pillow within pspy unit tests)

@xgarrido

Copy link
Copy Markdown
Collaborator

Actually pixell never faces this relatively recent issue since the latest github action they run is 3 weeks old and was still using pillow 9.5

@codecov-commenter

codecov-commenter commented Jul 10, 2023

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 49.39759% with 42 lines in your changes are missing coverage. Please review.

Project coverage is 29.43%. Comparing base (0c1f57a) to head (1df919a).
Report is 29 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
- Coverage   33.65%   29.43%   -4.23%     
==========================================
  Files          19       19              
  Lines        2095     2161      +66     
==========================================
- Hits          705      636      -69     
- Misses       1390     1525     +135     
Files Coverage Δ
pspy/so_cov.py 7.94% <ø> (-18.13%) ⬇️
pspy/so_mcm.py 51.27% <92.10%> (-6.81%) ⬇️
pspy/so_map_preprocessing.py 12.37% <13.33%> (-1.92%) ⬇️

... and 2 files with indirect coverage changes

@xzackli

xzackli commented Jul 11, 2023

Copy link
Copy Markdown
Contributor Author

@xgarrido @thibautlouis can I merge perhaps tomorrow, with a promise that tests will pass?

@xzackli xzackli changed the title polarization covariances (subset) polarization covariances (all) Jul 14, 2023
xgarrido added a commit that referenced this pull request Jul 17, 2023
pixell is broken with the latest version of pillow (see #65 (comment))
@xzackli

xzackli commented Apr 18, 2024

Copy link
Copy Markdown
Contributor Author

@xgarrido @zatkins2 this is ready to merge!

@xgarrido

Copy link
Copy Markdown
Collaborator

Adding @thibautlouis to the conversation since he is the grand master of pspy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants