Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Existing ACT tests use removed APIs and old coordinate compensation, and the replacement path lacks coverage.
3 open findings
What changed in this PR
Corrects ACT Depth-1 sky coverage coordinates and updates visualization and documentation.
Changes:
- Computes coverage from finite, nonzero pixel centers with normalized RA.
- Adds transactional
--replaceregeneration. - Updates coverage plotting and index documentation.
| File | Description |
|---|---|
README.md |
Documents coverage generation and replacement. |
mapcat/toolkit/update_sky_coverage.py |
Implements corrected tile calculation and replacement. |
mapcat/toolkit/plot_tiles.py |
Plots maps and coverage in celestial coordinates. |
mapcat/database/sky_coverage.py |
Corrects documented index ranges. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the coverage system to provide corrected coverage for ACT Depth-1 maps. The previous system was providing coverage squares that were 180 degrees off in RA, that was compensated for in the plotting script.