TF validation - #82
Conversation
| parser.add_argument( | ||
| "--globals", help="Path to the soopercool parameter file" | ||
| ) | ||
| parser.add_argument( |
There was a problem hiding this comment.
This is not needed in SOOPERCOOL as file structure is hardcoded. I believe this is to be able to use it to generate a bunch of filtered simulations externally ?
There was a problem hiding this comment.
That's right - SOOPERCOOL scripts such as this one should be flexible enough to be reused externally, especially if it is needed in many contexts. We could think of moving out_dir argument to a utility function instead of keeping it in the main script.
| @@ -723,7 +727,8 @@ def get_inverse_couplings(self, return_bpwf=False): | |||
| fname = f"couplings{filter_label}_{ftag1}_{ftag2}" | |||
| if not os.path.isfile(f"{couplings_dir}/{fname}.npz"): | |||
| raise ValueError( | |||
There was a problem hiding this comment.
Note to myself: I think this is not used in the pipeline. At some point we'll need to do a big cleanup of metadata_manager
adrien-laposta
left a comment
adrien-laposta
left a comment
There was a problem hiding this comment.
Sounds good, need to fix merge conflicts with main but shouldn't be too long
3 participants
Scripts to validate SOOPERCOOL transfer functions on simulations. Changes include:
validate_transfer_function_kspace.pythat only requires unfiltered TF estimation simsvalidate_transfer_function.pythat requires both filtered and unfiltered validation sims