Repository navigation
fix: include "max" in supported thinking levels - #24
Merged
Merged
Conversation
shyoldman
force-pushed
the
fix/thinking-level-max
branch
from
September 8, 2026 06:00
cb42500 to
59ed3a1
Compare
shyoldman
force-pushed
the
fix/thinking-level-max
branch
from
September 8, 2026 06:02
59ed3a1 to
df9f9bf
Compare
OnlyTomInSecond
pushed a commit
to OnlyTomInSecond/pi-provider-qoder
that referenced
this pull request
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Qoder's live catalog gives several models a
maxthinking effort, usually marked as the default. GLM-5.3-Flash comes back with:{ "high": {}, "max": { "is_default": true } }PI_THINKING_LEVELSenumerates["minimal", "low", "medium", "high", "xhigh"], somaxnever makes it into the map. pi's model picker then offers onlyhighfor that model, even though upstream defaults tomax. I hit this on GLM-5.3 and GLM-5.3-Flash; Kimi-K3 has the same shape. Qwen Ultimate also advertisesmax— you just don't notice because it hasxhightoo.The
ThinkingLeveltype in pi-ai already contains"max", and pi core treats it as a first-class level. The array lags behind the SDK it targets.Fix
Add
"max"toPI_THINKING_LEVELS, so it mapsmax → maxlike the other identity mappings.Verification
npm run lint,npm run check,npm test(138 tests) all pass./thinking maxon GLM-5.3-Flash and captured the outgoing request body (beforeqoderEncodeBody, via a local echo endpoint):{"model":"gfmodel","parameters":{"max_tokens":131072,"enable_thinking":true,"reasoning_effort":"max"}}