perf: optimize Qoder body encoding for large requests - #23
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optimize
qoderEncodeBody()to reduce CPU and GC overhead when encoding large request bodies.The previous implementation built an intermediate rearranged string and then appended the encoded output one character at a time with
out += ....With large Pi tool-call payloads, this caused significant V8 string flattening and garbage collection overhead.
Changes
rearrangedstringThe encoded wire format remains unchanged.
Observed issue
In real Pi sessions using Qoder providers, large requests could cause the Node main thread to stay at high CPU usage for a long time.
perfshowed hotspots around:String::SlowFlattenString::WriteToFlatRuntime_StringCharCodeAtmemmoveAfter replacing the string-concatenation path with the buffer-based implementation, the CPU spike no longer reproduced in the same workflow.
Validation