Skip to content

Fix release workflow git identity for Makefile sync PR - #19

Merged
silverbucket merged 1 commit into
masterfrom
cursor/release-git-identity-91b9
May 27, 2026
Merged

silverbucket merged 1 commit into
masterfrom
cursor/release-git-identity-91b9

Conversation

@silverbucket

@silverbucket silverbucket commented May 27, 2026 •

Copy link
Copy Markdown
Owner

Problem

Release job failed at Open Makefile sync pull request:

Author identity unknown
fatal: empty ident name ... not allowed

The merged release workflow checks out chore/bump-version-X.Y.Z from origin/master but never sets git user.name / user.email before git commit.

Fix

Set github-actions[bot] identity before commit; use git checkout -f so the branch starts clean from origin/master (not carrying the in-job Makefile edit from the build step).

Open in Web Open in Cursor 

Summary by CodeRabbit

  • Chores
    • Updated release workflow configuration to improve automation reliability.

Review Change Stack

Co-authored-by: Nick Jennings <silverbucket@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented May 27, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9ecaa78e-9c6d-4a33-b64b-e762462428d9

📥 Commits

Reviewing files that changed from the base of the PR and between 63d3221 and e8a762b.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

📝 Walkthrough

Walkthrough

The release workflow is updated to explicitly configure Git author identity for the GitHub Actions bot before creating the release branch, and the branch checkout command is changed to use a forced checkout (-f flag) instead of a non-forced checkout.

Changes

Release Workflow Configuration

Layer / File(s) Summary
Git author configuration and forced checkout
.github/workflows/release.yml
Release workflow now configures user.name and user.email for GitHub Actions bot and switches from git checkout -b to git checkout -f -b when creating the release branch from origin/master.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • silverbucket/dwatch#17: Both PRs modify the same .github/workflows/release.yml release-branch/feature-branch creation flow—specifically the git checkout ... -b usage (main PR adds -f) and the surrounding release branch setup logic.
  • silverbucket/dwatch#11: Both PRs modify the GitHub Actions release workflow in .github/workflows/release.yml, including the workflow's checkout/release-branch handling logic.

Suggested labels

ci

Poem

🐰 A rabbit commits with care,
Git identity in the air,
Forced checkout, clean and bright,
Release workflows done just right! 🚀

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: configuring Git identity for the release workflow to fix the Makefile sync PR creation process.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/release-git-identity-91b9

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Comment @coderabbitai help to get the list of available commands and usage tips.

@silverbucket silverbucket self-assigned this May 27, 2026
@silverbucket
silverbucket marked this pull request as ready for review May 27, 2026 16:24

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security review complete: no medium, high, or critical vulnerabilities identified in the modified workflow lines.

The PR adds a fixed github-actions[bot] commit identity and forces checkout before creating the Makefile sync branch. The branch/version values remain derived from the release version logic constrained to numeric SemVer, and the changed lines do not introduce a new injection, authz bypass, secret exposure, or supply-chain risk.

Open in Web View Automation 

Sent by Cursor Automation: Find vulnerabilities

@coderabbitai coderabbitai Bot added the ci label May 27, 2026
@silverbucket
silverbucket merged commit 97ad74b into master May 27, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants